On 7/23/25 5:41 AM, Aleksandar Rakic wrote:
Public
Hi,
Could you please let us know if you have any comments
on this patch?
Kind regards,
Aleksandar Rakic
________________________________________
From: Aleksandar Rakic <aleksandar.ra...@htecgroup.com>
Sent: Monday, March 17, 2025 2:23 PM
To: gcc-patches@gcc.gnu.org
Cc: Djordje Todorovic; c...@mips.com; richard.guent...@gmail.com;
ja...@redhat.com; mfortune; Faraz Shahbazker; Aleksandar Rakic
Subject: [PATCH v2 01/10] Add -mgrow-frame-downwards
From: mfortune <matthew.fort...@imgtec.com>
Grow the local frame down instead of up for mips16 code size.
By growing the frame downwards we get spill slots created at the lowest
address rather than highest address in a local frame. The benefit being
that when the frame is large the spill slots can still be accessed using
a 16bit instruction whereas it is less important for large local
variables to be accessed using short instructions as they are (probably)
accessed less frequently.
This is default on for MIPS16.
gcc/
* config/mips/mips.h (FRAME_GROWS_DOWNWARD) Allow the frame to
grow downwards for mips16 when -mgrow-frame-downwards is set.
* config/mips/mips.opt: Add -mgrow-frame-downwards option.
I was going to apply this patch as it seems reasonable and independent
of everything else. But unfortunately it appears that you have munged
tabs into spaces.
While we could potentially use "-l" to ignore that problem and allow the
patch to apply, but then the resulting change would have munged the tabs
into spaces, which violates our coding styles.
For small isolated changes I don't mind fixing this stuff, but you have
dozens of changes and I don't have the time to fix each one you've
submitted.
It's not clear if the patch was munged by your mailer or in your local
tree, but it definitely needs to get resolved before these patches can
go forward.
Jeff
