On Fri, Jun 13, 2025, at 2:02 PM, Joseph Myers wrote:
> On Wed, 21 May 2025, Pietro Monteiro wrote:
>
>> lto-plugin/ChangeLog:
>>
>> * configure: Regenerate.
>> * configure.ac: Replace AC_CANONICAL_SYSTEM with AC_CANONICAL_SYSTEM.
>
> That ChangeLog entry is clearly incorrect.
Sorry. It should read "configure.ac: Replace AC_CANONICAL_SYSTEM with
AC_CANONICAL_TARGET."
>> diff --git a/config/asmcfi.m4 b/config/asmcfi.m4
>> index a725aa11de4..dc15edb2701 100644
>> --- a/config/asmcfi.m4
>> +++ b/config/asmcfi.m4
>> @@ -4,12 +4,14 @@ AC_DEFUN([GCC_AS_CFI_PSEUDO_OP],
>> [AC_CACHE_CHECK([assembler .cfi pseudo-op support],
>> gcc_cv_as_cfi_pseudo_op, [
>> gcc_cv_as_cfi_pseudo_op=unknown
>> - AC_TRY_COMPILE([asm (".cfi_startproc\n\t.cfi_endproc");],,
>> - [gcc_cv_as_cfi_pseudo_op=yes],
>> - [gcc_cv_as_cfi_pseudo_op=no])
>> + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[asm
>> (".cfi_startproc\n\t.cfi_endproc");]],
>> + [[]])],
>> + [gcc_cv_as_cfi_pseudo_op=yes],
>> + [gcc_cv_as_cfi_pseudo_op=no])
>> ])
>> if test "x$gcc_cv_as_cfi_pseudo_op" = xyes; then
>> AC_DEFINE(HAVE_AS_CFI_PSEUDO_OP, 1,
>> [Define if your assembler supports .cfi_* directives.])
>> fi
>> ])
>> +\
>
> Adding this \ at end of file looks suspect.
>
> OK with that ChangeLog entry fixed and the stray \ at end of file removed
> (assuming the same output files are still generated after that change).
I applied the patch on top of trunk (), removed the stray '\' from
config/asmcfi.m4. Regenerating all autoconf/automake files showed no difference
from the patch.
Should I send a v2 with the correction or can a maintainer fix it before
committing?
> --
> Joseph S. Myers
> josmy...@redhat.com
Thanks,
pietro
