On Thu, 5 Jun 2025 at 12:23, Luc Grosheintz <luc.groshei...@gmail.com> wrote: > > > > On 6/5/25 10:18, Tomasz Kaminski wrote: > > On Wed, Jun 4, 2025 at 5:15 PM Luc Grosheintz <luc.groshei...@gmail.com> > > wrote: > > > >> Implements a suite of tests for the currently implemented parts of > >> layout_left. The individual tests are templated over the layout type, to > >> allow reuse as more layouts are added. > >> > >> libstdc++-v3/ChangeLog: > >> > >> * testsuite/23_containers/mdspan/layouts/class_mandate_neg.cc: New > >> test. > >> * testsuite/23_containers/mdspan/layouts/ctors.cc: New test. > >> * testsuite/23_containers/mdspan/layouts/empty.cc: New test. > >> * testsuite/23_containers/mdspan/layouts/mapping.cc: New test. > >> > >> Signed-off-by: Luc Grosheintz <luc.groshei...@gmail.com> > >> --- > >> > > Again LGTM. The new test for dynamic overflow in empty.cc are nice addition. > > The testsuite you have created seem like something other implementation may > > look checking > > if they pass. > > Thank you! We know for sure that both libc++ and MSVCs implementation > will not pass these tests. Especially the corner cases we figured out > surrounding empty extents, will uncover bugs in the two other major > implementations. > > I reported some of the bugs on the CLang issue tracker, but haven't > heard anything yet. > > At the end, i.e. when we have std::mdspan, I was thinking of running > their test suite, to see what we missed.
I used to run the libc++ tests against libstdc++ often, but I haven't done it for a couple of years - I can't even figure out how to run their tests against libstdc++ now!
