Hi! On Mon, Jun 02, 2025 at 05:50:08PM +0200, Martin Uecker wrote: > According to the discussion in the bugzilla there seems to be > some consensus to activate the warning for -Wextra (I am also > looking into implementing the suggested improvements that may > make it suitable fo r-Wall). When making this change, I also > noticed that it was not working for -Wc++-compat due to a typo.
Do you have any data showing that -Wextra is good for this warning (and that -Wall is not)? -Wall should have essentially no false positives, -Wextra is allowed to be a bit more annoying, but the requirements for the two are essentially the same, just the limit "this is *too* annoying" shifted a bit. Why do this in -Wc++-compat at all? You don't say. Well, you say that is a bugfix, so it should be a separate (and trivial) patch. Segher
