On Wed, 2025-05-28 at 18:10 +0200, Andreas Schwab wrote: > On Mai 28 2025, John Paul Adrian Glaubitz wrote: > > > Shouldn't the #undef in linux.h undefine DEFAULT_PCC_STRUCT_RETURN and not > > PCC_STATIC_STRUCT_RETURN? > > No, they are separate target options. PCC_STATIC_STRUCT_RETURN is no > longer defined by default, so this is redundant now.
OK, guess someone can drop that line then. > > And, secondly, shouldn't the comment in linux.h be corrected since > > apparently linux.h and netbsd-elf.h disagree on what the SVR4 ABI > > specifies how structs and unions are returned? > > This is controlled by TARGET_RETURN_IN_MEMORY if > DEFAULT_PCC_STRUCT_RETURN is 0. I was talking about the comments, not the code since NetBSD and Linux disagree on what the SVR4 ABI claims. Btw, shouldn't EMPTY_FIELD_BOUNDARY not changed by -malign-int to 32 similar to BIGGEST_ALIGNMENT (see netbsd-elf.h)? And what about the value for STACK_BOUNDARY? It seems to be 16 for many Linux targets while it's 32 for NetBSD. Is there a reason why it's 16-bit- aligned on Linux? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
