On 5/9/25 11:21 AM, Sam James wrote:
Sam James <s...@gentoo.org> writes:
When working on xz, I set `-Werror=suggest-attribute=returns_nonnull`, and
the build failed (as I expected it to), but with no visible error from
the compiler. There's a mysterious '>/dev/null 2>&1' on the second line where
liblzma_la-common.o is built without PIC.
With -fPIC, IPA doesn't end up doing attribute discovery. Without it,
it does. This behaviour is IMO undesirable and we should patch it out.
This also affects building GCC and is particularly unfortunate if we hit
an ICE.
See https://bugs.gentoo.org/135865 and
https://lists.gnu.org/archive/html/libtool-patches/2024-08/msg00000.html.
* ltmain.sh (func_mode_compile): Don't suppress stdout/stderr for no-PIC
build.
---
I've proposed this upstream and it ended up being bikeshedded a bit. I've
been running this locally for nearly a year now and on IRC, others
expressed interest in this, as it causes pain when debugging.
ping
Well, ideally we'd not deviate any more than absolutely necessary from
upstream. Is there any final conclusion from the upstream discussion?
jeff
