On Tue, 22 Apr 2025, Richard Sandiford wrote: > Ping, since it sounds from irc like the release is coming soon :)
Fine with me. > Richard Sandiford <richard.sandif...@arm.com> writes: > > gcc.dg/tree-ssa/predcom-8.c fails on aarch64 for the reasons discussed > > in the PR trail. The fix didn't make it into GCC 15, so this patch > > XFAILs the test instead. > > > > Other targets might benefit from an XFAIL too, but people who work on > > those targets would be better placed to know the right conditions. > > > > Tested on aarch64-linux-gnu. OK for GCC 15? > > > > FWIW, I was holding off on doing this in case the patch did make it in. > > With the patch applied, I get clean results locally on aarch64-linux-gnu > > for all testsuites except libphobos, where the some math routines are > > missing AArch64 support. > > > > Richard > > > > > > gcc/testsuite/ > > PR tree-optimization/118407 > > * gcc.dg/tree-ssa/predcom-8.c: Add XFAIL for aarch64. > > --- > > gcc/testsuite/gcc.dg/tree-ssa/predcom-8.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/predcom-8.c > > b/gcc/testsuite/gcc.dg/tree-ssa/predcom-8.c > > index dcddf573145..22e4882c363 100644 > > --- a/gcc/testsuite/gcc.dg/tree-ssa/predcom-8.c > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/predcom-8.c > > @@ -10,4 +10,4 @@ int is_sorted(int *a, int n) > > } > > > > /* { dg-final { scan-tree-dump "Executing predictive commoning without > > unrolling" "pcom" } } */ > > -/* { dg-final { scan-tree-dump-not "Invalid sum" "pcom" } } */ > > +/* { dg-final { scan-tree-dump-not "Invalid sum" "pcom" { xfail > > aarch64*-*-* } } } */ > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)