On Sat, 2025-04-19 at 08:13 -0600, Jeff Law wrote: > > On 1/1/25 10:02 AM, Jiaxun Yang wrote: > > Implement fenv rouding and exceptions for soft-fp, as per SuperH > > arch specification. > > > > No new tests required, as it's already covered by many torture tests > > with fenv_exceptions. > > > > PR target/118257 > > > > libgcc/ChangeLog: > > > > * config/sh/sfp-machine.h (_FPU_GETCW): Implement with builtin. > > (_FPU_SETCW): Likewise. > > (FP_EX_ENABLE_SHIFT): Derive from arch spec. > > (FP_EX_CAUSE_SHIFT): Likewise. > > (FP_RND_MASK): Likewise. > > (FP_EX_INVALID): Likewise. > > (FP_EX_DIVZERO): Likewise. > > (FP_EX_ALL): Likewise. > > (FP_EX_OVERFLOW): Likewise. > > (FP_EX_UNDERFLOW): Likewise. > > (FP_EX_INEXACT): Likewise. > > (_FP_DECL_EX): Declear default FCSR value. > > (FP_RND_NEAREST): Derive from arch spec. > > (FP_RND_ZERO): Likewise. > > (FP_INIT_ROUNDMODE): Likewise. > > (FP_ROUNDMODE): Likewise. > > (FP_TRAPPING_EXCEPTIONS): Likewise. > > (FP_HANDLE_EXCEPTIONS): Implement with _FPU_SETCW. > I've pushed to the trunk as well as the assumption that you've got these > various constants right. Oleg, hope I'm not stepping on your toes here, > I'm just starting to work through some of the safer gcc-16 stuff. >
No, not at all. Thanks for keeping an eye on it! I think the committed v2 patch looked good. Best regards, Oleg Endo