On 4/18/25 9:13 AM, Paul Richard Thomas wrote:
Hi Andre,
On Thu, 17 Apr 2025 at 14:20, Andre Vehreschild <ve...@gmx.de
<mailto:ve...@gmx.de>> wrote:
Hi Jerry,
thanks for the review and sorry for the long delay. With publishing
the team's
patches for gfortran, I also created a pull request for
OpenCoarrays. There I
was asked to add some testcase with more "beef" in it. I.e.
something that
really makes use of teams and not only smoke tests it. This
unfortunately made
me discover some issues, that I needed to fix. The attached patch 6/5
addresses these issues. Some of them were as easy as not being able
to exit out
of change team block or an end team with a label not being parsed
correctly and
not generated in resulting binary. Others were more subtle, like
having to
create coarray tokens for association in the change team.
The attached patch addresses all these issues and
bootstraps and regtests ok on x86_64-pc-linux-gnu / F41. Ok for
mainline?
Btw, do I still merge to master, or am I to wait for the bump to
16th master?
Regards,
Andre
This all looks good to me, except for two tiny nits. It looks as if we
are already on 16-branch :-(
I have been religiously ending ChangeLogs at column 72 since I started
supporting gfortran. If this is still a requirement, I suggest:
line 14: s/it is/it's/
line 23: carry "are" over to the next line.
OK for mainline and, I would suggest, backporting to 15-branch asap.
Thanks for the patch
Paul
Agree, Andre OK for 16, proceed.
Jerry
