Hi!
On 2025-04-15T00:22:26+0200, I wrote:
> --- a/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C
> +++ b/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C
> +/* Help nvptx offloading overcome a code generation issue;
> + PR106445, PR118518. */
> +#define ALWAYS_INLINE __attribute__((always_inline))
> +
> #pragma omp begin declare target
>
> bool ok = false;
> @@ -19,10 +20,12 @@ bool ok = false;
> template <typename T>
> struct C
> {
> + ALWAYS_INLINE
> C()
> {
> ok = true;
> }
> + ALWAYS_INLINE
> C(int) {};
> ~C() {};
Pushed to trunk branch commit 518efed8cb7d003cd85477060b1fe926a2d7a53b
"Remove 'ALWAYS_INLINE' workaround in
'libgomp.c++/target-exceptions-pr118794-1.C'",
see attached.
Grüße
Thomas
>From 518efed8cb7d003cd85477060b1fe926a2d7a53b Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschwi...@baylibre.com>
Date: Wed, 16 Apr 2025 16:52:08 +0200
Subject: [PATCH] Remove 'ALWAYS_INLINE' workaround in
'libgomp.c++/target-exceptions-pr118794-1.C'
With commit ca9cffe737d20953082333dacebb65d4261e0d0c
"For nvptx offloading, make sure to emit C++ constructor, destructor aliases [PR97106]",
we're able to remove the 'ALWAYS_INLINE' workaround added in
commit fe283dba774be57b705a7a871b000d2894d2e553
"GCN, nvptx: Support '-mfake-exceptions', and use it for offloading compilation [PR118794]".
libgomp/
* testsuite/libgomp.c++/target-exceptions-pr118794-1.C: Remove
'ALWAYS_INLINE' workaround.
---
.../testsuite/libgomp.c++/target-exceptions-pr118794-1.C | 6 ------
1 file changed, 6 deletions(-)
diff --git a/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C b/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C
index a73e7f897be..24e3d076a1b 100644
--- a/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C
+++ b/libgomp/testsuite/libgomp.c++/target-exceptions-pr118794-1.C
@@ -9,10 +9,6 @@
/* See also '../../../gcc/testsuite/g++.target/gcn/exceptions-pr118794-1.C',
'../../../gcc/testsuite/g++.target/nvptx/exceptions-pr118794-1.C'. */
-/* Help nvptx offloading overcome a code generation issue;
- PR106445, PR118518. */
-#define ALWAYS_INLINE __attribute__((always_inline))
-
#pragma omp begin declare target
bool ok = false;
@@ -20,12 +16,10 @@ bool ok = false;
template <typename T>
struct C
{
- ALWAYS_INLINE
C()
{
ok = true;
}
- ALWAYS_INLINE
C(int) {};
~C() {};
--
2.34.1
