On Fri, Aug 3, 2012 at 8:02 AM, JonY <jo...@users.sourceforge.net> wrote:
> On 8/3/2012 22:37, Ian Lance Taylor wrote:
>> On Fri, Aug 3, 2012 at 7:01 AM, JonY <jo...@users.sourceforge.net> wrote:
>>>
>>> For correctness sake, determine version from BASE-VER file instead of
>>> calling compiler. This allows better toleration with bad Canadian cross
>>> setups where host gcc version is of different version from target.
>>>
>>> Patch OK?
>>
>> The patch is OK but you need a ChangeLog entry.
>>
>> Thanks.
>>
>> Ian
>>
>
> ChangeLog OK?
>
> 2012-08-03  Jonathan Yong  <jo...@users.sourceforge.net>
>
>         * Makefile.in: Use BASE-VER file instead of host compiler
>         to better tolerate setups where host gcc version differs from
>         target version.

Missing item you are changing, gives explanation normally omitted from
ChangeLog entries.  I would suggest this:

    * Makefile.in (version): Set to BASE-VER from gcc directory.

Ian

Reply via email to