Hi! I've noticed ../../../libquadmath/printf/gmp-impl.h:104:18: warning: old-style function definition [-Wold-style-definition] ../../../libquadmath/printf/gmp-impl.h:104:18: warning: old-style function definition [-Wold-style-definition] ../../../libquadmath/printf/gmp-impl.h:104:18: warning: old-style function definition [-Wold-style-definition] ../../../libquadmath/strtod/strtod_l.c:456:22: warning: old-style function definition [-Wold-style-definition] warnings during bootstrap (clearly since the switch to -std=gnu23 by default).
The following patch fixes those in libquadmath, the only other warnings are in zlib. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2025-04-01 Jakub Jelinek <ja...@redhat.com> * strtod/strtod_l.c (____STRTOF_INTERNAL): Avoid old-style function definitions. * printf/addmul_1.c (mpn_addmul_1): Likewise. * printf/mul_1.c (mpn_mul_1): Likewise. * printf/submul_1.c (mpn_submul_1): Likewise. --- libquadmath/strtod/strtod_l.c.jj 2023-03-03 00:40:08.543090208 +0100 +++ libquadmath/strtod/strtod_l.c 2025-03-31 17:36:37.764655933 +0200 @@ -468,10 +468,7 @@ str_to_mpn (const STRING_TYPE *str, int return 0.0. If the number is too big to be represented, set `errno' to ERANGE and return HUGE_VAL with the appropriate sign. */ FLOAT -____STRTOF_INTERNAL (nptr, endptr, group) - const STRING_TYPE *nptr; - STRING_TYPE **endptr; - int group; +____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group) { int negative; /* The sign of the number. */ MPN_VAR (num); /* MP representation of the number. */ --- libquadmath/printf/addmul_1.c.jj 2020-01-12 11:54:39.787362505 +0100 +++ libquadmath/printf/addmul_1.c 2025-03-31 17:39:15.887562328 +0200 @@ -26,11 +26,8 @@ MA 02111-1307, USA. */ #include "gmp-impl.h" mp_limb_t -mpn_addmul_1 (res_ptr, s1_ptr, s1_size, s2_limb) - register mp_ptr res_ptr; - register mp_srcptr s1_ptr; - mp_size_t s1_size; - register mp_limb_t s2_limb; +mpn_addmul_1 (mp_ptr res_ptr, mp_srcptr s1_ptr, mp_size_t s1_size, + mp_limb_t s2_limb) { register mp_limb_t cy_limb; register mp_size_t j; --- libquadmath/printf/mul_1.c.jj 2020-01-12 11:54:39.787362505 +0100 +++ libquadmath/printf/mul_1.c 2025-03-31 17:39:40.549235797 +0200 @@ -24,11 +24,8 @@ MA 02111-1307, USA. */ #include "gmp-impl.h" mp_limb_t -mpn_mul_1 (res_ptr, s1_ptr, s1_size, s2_limb) - register mp_ptr res_ptr; - register mp_srcptr s1_ptr; - mp_size_t s1_size; - register mp_limb_t s2_limb; +mpn_mul_1 (mp_ptr res_ptr, mp_srcptr s1_ptr, mp_size_t s1_size, + mp_limb_t s2_limb) { register mp_limb_t cy_limb; register mp_size_t j; --- libquadmath/printf/submul_1.c.jj 2020-01-12 11:54:39.788362490 +0100 +++ libquadmath/printf/submul_1.c 2025-03-31 17:40:07.205882853 +0200 @@ -26,11 +26,8 @@ MA 02111-1307, USA. */ #include "gmp-impl.h" mp_limb_t -mpn_submul_1 (res_ptr, s1_ptr, s1_size, s2_limb) - register mp_ptr res_ptr; - register mp_srcptr s1_ptr; - mp_size_t s1_size; - register mp_limb_t s2_limb; +mpn_submul_1 (mp_ptr res_ptr, mp_srcptr s1_ptr, mp_size_t s1_size, + mp_limb_t s2_limb) { register mp_limb_t cy_limb; register mp_size_t j; Jakub