On Fri, Mar 21, 2025 at 10:08:05AM +0100, Richard Biener wrote:
> On Thu, 20 Mar 2025, Richard Biener wrote:
>
> > The following avoids early runtime initialization of cbl_field_t
> > objects which, when using tree to represent the current _Float128
> > data, segfaults as tree data like float128_type_node is not yet
> > initialized. The solution is to move the global data to
> > symbol_table_init which is the only user and it already has one
> > such instance locally, the 'constants' array.
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu.
> >
> > OK?
>
> I've now pushed the first prerequesite patch for the larger
> _Float -> tree change, but this one is still unreviewed (though
> borderly obvious). Can somebody ack it? That way testing
> of the real change will hopefully simplify.
>
> Richard.
>
> > * symbols.cc (empty_float, empty_comp5, empty_literal,
> > empty_conditional, debug_registers, special_registers): Move
> > global cbl_field_t typed data to ...
> > (symbol_table_init): ... local scope here.
LGTM.
Jakub
