On 3/25/25 1:42 AM, jeevitha wrote:
> gcc/testsuite/
> PR testsuite/119382
> * gcc.target/powerpc/vsx-builtin-7.c: Add '-fno-ipa-icf' to dg-options.
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-builtin-7.c
> b/gcc/testsuite/gcc.target/powerpc/vsx-builtin-7.c
> index 5095d5030fd..78e4e23d102 100644
> --- a/gcc/testsuite/gcc.target/powerpc/vsx-builtin-7.c
> +++ b/gcc/testsuite/gcc.target/powerpc/vsx-builtin-7.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile { target { powerpc*-*-* } } } */
> /* { dg-skip-if "" { powerpc*-*-darwin* } } */
> -/* { dg-options "-O2 -mdejagnu-cpu=power7 -fno-inline-functions" } */
> +/* { dg-options "-O2 -mdejagnu-cpu=power7 -fno-inline-functions
> -fno-ipa-icf" } */
> /* { dg-require-effective-target powerpc_vsx } */
>
> /* Test simple extract/insert/slat operations. Make sure all types are
I REALLY dislike these BIG built-in test cases that test for all possible
built-ins and then do multiple insn scans. Much better would be having
many small test cases that test for one specific thing, rather than testing
lots of things. As shown here, they're pretty fragile to changes in
the compiler.
That said, I'm not sure it's really worth splitting this older Power7
test case up, so I guess adding -fno-ipa-icf is probably the best/easiest
of all of the bad options.
Segher, any reason you can give on why we shouldn't go the easy route to
"fix" (yes, these are air-quotes) this by using -fno-ipa-icf?
Peter
