I am taking your word for it on testing.

LGTM

> -----Original Message-----
> From: Iain Sandoe <iains....@gmail.com>
> Sent: Monday, March 24, 2025 05:01
> To: jklow...@cobolworx.com; rdub...@symas.com; gcc-patches@gcc.gnu.org
> Subject: [PATCH] libgcobol: Ensure that config.h is included.
> 
> This one is quite simple; we currently go through the configuration
> process and mostly ignore its output.  This fixes that so that we may
> use the configured values to make things more portable.
> 
> tested on x86_64-linux,darwin aarch64-linux, OK for trunk?
> thanks
> Iain
> 
> --- 8< ---
> 
> This includes config.h before any other project-related headers
> or sources so that they properly make use of the values determined
> by configure.
> 
> libgcobol/ChangeLog:
> 
>       * charmaps.cc: Include config.h.
>       * constants.cc: Likewise.
>       * gfileio.cc: Likewise.
>       * gmath.cc: Likewise.
>       * io.cc: Likewise.
>       * libgcobol.cc: Likewise.
>       * valconv.cc: Likewise.
> 
> Signed-off-by: Iain Sandoe <i...@sandoe.co.uk>
> ---
>  libgcobol/charmaps.cc  | 2 ++
>  libgcobol/constants.cc | 2 ++
>  libgcobol/gfileio.cc   | 2 ++
>  libgcobol/gmath.cc     | 2 ++
>  libgcobol/io.cc        | 3 +++
>  libgcobol/libgcobol.cc | 2 ++
>  libgcobol/valconv.cc   | 2 ++
>  7 files changed, 15 insertions(+)
> 
> diff --git a/libgcobol/charmaps.cc b/libgcobol/charmaps.cc
> index 6a7975030df..6ad74adbc74 100644
> --- a/libgcobol/charmaps.cc
> +++ b/libgcobol/charmaps.cc
> @@ -38,6 +38,8 @@
>  #include <locale.h>
>  #include <iconv.h>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "common-defs.h"
>  #include "io.h"
> diff --git a/libgcobol/constants.cc b/libgcobol/constants.cc
> index 3b4d68a730b..0aa9373492e 100644
> --- a/libgcobol/constants.cc
> +++ b/libgcobol/constants.cc
> @@ -40,6 +40,8 @@
>  #include <algorithm>
>  #include <unordered_map>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "io.h"
>  #include "common-defs.h"
> diff --git a/libgcobol/gfileio.cc b/libgcobol/gfileio.cc
> index 9852dbf0f35..74c5a073c41 100644
> --- a/libgcobol/gfileio.cc
> +++ b/libgcobol/gfileio.cc
> @@ -40,6 +40,8 @@
>  #include <unistd.h>
>  #include <algorithm>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "io.h"
>  #include "common-defs.h"
> diff --git a/libgcobol/gmath.cc b/libgcobol/gmath.cc
> index 2af0e8a8614..fb2eae38ef3 100644
> --- a/libgcobol/gmath.cc
> +++ b/libgcobol/gmath.cc
> @@ -39,6 +39,8 @@
>  #include <unistd.h>
>  #include <algorithm>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "common-defs.h"
>  #include "io.h"
> diff --git a/libgcobol/io.cc b/libgcobol/io.cc
> index 4dca42e0bad..95e1d026686 100644
> --- a/libgcobol/io.cc
> +++ b/libgcobol/io.cc
> @@ -27,6 +27,9 @@
>   * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE
>   * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */
> +
> +#include "config.h"
> +
>  #include "io.h"
>  #include "stdio.h"
>  #include "stdlib.h"
> diff --git a/libgcobol/libgcobol.cc b/libgcobol/libgcobol.cc
> index 0890835822c..6aeaaa2c142 100644
> --- a/libgcobol/libgcobol.cc
> +++ b/libgcobol/libgcobol.cc
> @@ -49,6 +49,8 @@
>  #include <dirent.h>
>  #include <sys/resource.h>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "common-defs.h"
>  #include "io.h"
> diff --git a/libgcobol/valconv.cc b/libgcobol/valconv.cc
> index 0b80d72cc3a..41a933d68db 100644
> --- a/libgcobol/valconv.cc
> +++ b/libgcobol/valconv.cc
> @@ -35,6 +35,8 @@
>  #include <algorithm>
>  #include <unordered_map>
> 
> +#include "config.h"
> +
>  #include "ec.h"
>  #include "common-defs.h"
>  #include "charmaps.h"
> --
> 2.39.2 (Apple Git-143)

Reply via email to