Hi Robert, On Wed Mar 12, 2025 at 2:12 PM CET, Robert Dubner wrote: > > >> -----Original Message----- >> From: Simon Martin <si...@nasilyan.com> >> Sent: Wednesday, March 12, 2025 06:27 >> To: gcc-patches@gcc.gnu.org >> Cc: rdub...@symas.com >> Subject: [PATCH] cobol: Remove unnecesssary CPPFLAGS update and restore >> MacOS build >> >> The build currently fails on MacOS even when the Cobol front-end and >> libgcobol builds are disabled. >> >> The problem is that gcc/cobol/Make-lang.in adds -Iinclude to CPPFLAGS, >> which somehow makes clang unhappy about the include order: >> error: <cstddef> tried including <stddef.h> but didn't find libc++'s >> <stddef.h> header. This usually means that your header search paths >> are not configured properly. >> >> It turns out that this addition is unnecessary: simply removing it fixes >> the build on MacOS, without impacting the build x86_64-pc-linux-gnu when >> configured with --enable-languages=default,cobol. >> >> It feels like there might be more cleanup opportunities there, but they >> can be taken care of later. >> >> OK for trunk? > > I am still trying to get up to speed, here. Jim and I have been living in > our tidy little world; he's been developing in an Ubuntu instances on a > aarch64 Mac M2, and I've been developing on an Ubuntu environment on a > x86_64. This is a lot more standard than the 2013 Mac I was compiling on :-) I definitely expect the build to break at times on it, and it's fine.
> But now we've gotten off the train at Grand Central Station, and I feel > like there are cars whizzing by, and horns honking, and pedestrians > pushing past me muttering, "Brush the hay out of your hair!" I copied you primarily for information and as Cobol maintainer, but did not expect any action from you; sorry if it was unclear. > So, if I am supposed to answer that question, and if indeed the change > doesn't affect x86_64-pc-linux-gnu builds, then by all means, it is "OK > for trunk". Thanks. Richard already approved and I've pushed the fix, so it's all good. Simon
