On 2/24/25 3:22 AM, Yuriy Kolerov wrote:
zce must imply zcf but this rule was corrupted after
refactoring in 9e12010b5e724277ea. This may be observed
ater generating an .s file from any source code file with
-mriscv-attribute -march=rv32if_zce -mabi=ilp32 -S
options. A full march will be presented in arch attribute:
rv32i2p1_f2p2_zicsr2p0_zca1p0_zcb1p0_zce1p0_zcmp1p0_zcmt1p0
As you see, zcf is not presented here though f_zce pair is
passed in -march. According to The RISC-V Instruction
Set Manual:
Specifying Zce on RV32 with F includes Zca, Zcb, Zcmp,
Zcmt and Zcf.
PR target/118906
gcc/ChangeLog:
* common/config/riscv/riscv-common.cc: fix zce to zcf
implication.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/attribute-zce-1.c: New test.
* gcc.target/riscv/attribute-zce-2.c: New test.
* gcc.target/riscv/attribute-zce-3.c: New test.
* gcc.target/riscv/attribute-zce-4.c: New test.
I'm not 100% sure this is implementation is correct. My understanding
is that zce implies zcf iff rv32 and f are also enabled. So don't you
need to verify that rv32 and f are enabled? Or is that done elsewhere?
Though it looks like the other cases zce -> {zca, zcb, zcmp, zcmp} don't
have that check.
It feels like I'm missing something in how all this works.
Kito, you know this stuff better than I, thoughts?
Jeff
