Kyrylo Tkachov <ktkac...@nvidia.com> writes: > Hi Soumya > >> On 18 Feb 2025, at 09:12, Soumya AR <soum...@nvidia.com> wrote: >> >> generic_armv8_a.h defines generic_armv8_a_prefetch_tune but still uses >> generic_prefetch_tune in generic_armv8_a_tunings. >> >> This patch updates the pointer to generic_armv8_a_prefetch_tune. >> >> This patch was bootstrapped and regtested on aarch64-linux-gnu, no >> regression. >> >> Ok for GCC 15 now? > > Yes, this looks like a simple oversight. > Ok to push to master.
I suppose the alternative would be to remove generic_armv8_a_prefetch_tune, since it's (deliberately) identical to generic_prefetch_tune. > Thanks, > Kyrill > >> >> Signed-off-by: Soumya AR <soum...@nvidia.com> >> >> gcc/ChangeLog: >> >> * config/aarch64/tuning_models/generic_armv8_a.h: Updated prefetch >> struct pointer. >> >> --- >> gcc/config/aarch64/tuning_models/generic_armv8_a.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/config/aarch64/tuning_models/generic_armv8_a.h >> b/gcc/config/aarch64/tuning_models/generic_armv8_a.h >> index 35de3f03296..01080cade46 100644 >> --- a/gcc/config/aarch64/tuning_models/generic_armv8_a.h >> +++ b/gcc/config/aarch64/tuning_models/generic_armv8_a.h >> @@ -184,7 +184,7 @@ static const struct tune_params generic_armv8_a_tunings = >> (AARCH64_EXTRA_TUNE_BASE >> | AARCH64_EXTRA_TUNE_CSE_SVE_VL_CONSTANTS >> | AARCH64_EXTRA_TUNE_MATCHED_VECTOR_THROUGHPUT), /* tune_flags. */ >> - &generic_prefetch_tune, >> + &generic_armv8_a_prefetch_tune, >> AARCH64_LDP_STP_POLICY_ALWAYS, /* ldp_policy_model. */ >> AARCH64_LDP_STP_POLICY_ALWAYS /* stp_policy_model. */ >> }; >> -- >> 2.34.1 >> >> >> >>
