On Sun, 16 Feb 2025 11:59:37 +0800, Jeff Law wrote:
> 
> 
> On 2/14/25 12:12 AM, Jin Ma wrote:
> > When using riscv_v_abi, the return and arguments of the function should
> > be adequately checked to avoid ICE.
> > 
> >     PR target/118872
> > 
> > gcc/ChangeLog:
> > 
> >     * config/riscv/riscv.cc (riscv_fntype_abi): Strengthen the logic
> >     of the check to avoid missing the error report.
> > 
> > gcc/testsuite/ChangeLog:
> > 
> >     * gcc.target/riscv/rvv/base/pr118872.c: New test.
> Note this is causing regressions in the pre-commit CI system:
> 
> 
> > https://github.com/ewlu/gcc-precommit-ci/issues/3096#issuecomment-2659969415
> 
> 
> Can you please take care of those regressions.  Thanks.

I sincerely apologize for the issues caused. I will work on resolving them. 
Before
submitting, I only performed regression tests locally for rv64gc-lp64d and 
rv32gc-ilp32d,
and it seems that was insufficient.

Should I also run regressions for the following?
  rv32gc-ilp32d
  rv32gc_zba_zbb_zbc_zbs-ilp32d
  rv32gcv-ilp32d
  rv32imc_zba_zbb_zbc_zbs-ilp32
  rv64gc-lp64d
  rv64gc_zba_zbb_zbc_zbs-lp64d
  rv64gcv-lp64d

Additionally, I've noticed that when I run regression tests on the master 
branch using
rv64gcv-lp64d or rv32gcv-ilp32d without applying any patches, there are still 
over 300
failures related to RVV. I'm unsure if there is an issue with my testing 
approach.

https://gcc.gnu.org/pipermail/gcc-testresults/2025-February/838574.html

Best regards,
Jin Ma

> jeff

Reply via email to