Re: [PATCH] x86: Correct ASM_OUTPUT_SYMBOL_REF

[Uros Bizjak]

On Tue, Feb 11, 2025 at 7:13 AM H.J. Lu <hjl.to...@gmail.com> wrote:
>
> x is not a macro argument.  It just happens to work as final.cc passes
> x for 2nd argument:
>
> final.cc:      ASM_OUTPUT_SYMBOL_REF (file, x);
>
> PR target/118825
> * config/i386/i386.h (ASM_OUTPUT_SYMBOL_REF): Replace x with
> SYM.

> -      = assemble_name_resolve (XSTR (x, 0)); \
> +      = assemble_name_resolve (XSTR ((SYM), 0)); \

No need for parenthesis when macro argument is used in a function call.

OK with the above change.

Thanks,
Uros.

> --
> H.J.