> Hi José! > > I intend to provide a few comments to specific code changes that I might > have some clue about, later on -- "my later"; ask my wife what span of > time that might mean... ;-)
Thank you :) > > In the following, so far, just a few high-level comments: > > > On 2025-01-01T03:09:44+0100, "Jose E. Marchesi" <jose.march...@oracle.com> > wrote: >> The parser used in this front-end has been borrowed and adapted from >> Algol 68 Genie, an Algol 68 interpreter written by Marcel van der >> Veer. It is worth noting that this parser is not your typical garden >> variety parser, as it is capable of effectively parsing the two-level >> grammar of Algol 68, which is no small deal. Parsing Algol 68 is >> notoriously difficult, and without Marcel's careful work of many years >> this front-end would most probably not exist. > > In order to give credit where credit is due, I suggest: have a separate > commit with Git author "(J.?) Marcel van der Veer" (possibly "empty" > email address: "<>", unless you have permission to use a proper one?), > and in that commit add to 'gcc/algol68/' the (still unused) files, > verbatim, that you're taking from him/Algol 68 Genie. In a following > commit then recast those into the form that you've currently got them. > (If you agree to this proposal, and unless you'd like to do it yourself, > I'm happy to do the corresponding "Git magic".) In addition to > attributing provenance, this would also allow for easier > tracking/incorporating of changes to the original files, should that > happen. Thats a good idea, will do so. The source of the parser original source files is a release tarball from 2023. Marcel doesn't keep a public git/vcn. > This doesn't seem completely unlikely, given that you're stating > "Copyright (C) 2001-2023 J. Marcel van der Veer", which is just two years > ago. There has been an additional Genie release since then, in January 2025, precisely to fix a bug I found while integrating it in GCC. >> All the C and C++ code is formatted following the GNU Coding >> Standards. > > I'm actually not a fan of reformatting imported files, but I guess I > don't set the rules there. ;-) I took the pain of reformatting (manually) and adapting the imported sources because this is a one-time import. The parser already diverged and there are a lot of changes to come (like the separated compilation and modules system) which make little sense in an interpreter. >> The original parser is copyright Marcel van der Veer. > > I suppose you've settled the copyright and licensing conditions for this, > being able to apply GPLv3+ to it, and all that. Yes of course. The original source is GPLv3+, it has a single copyright owner, and I contacted Marcel before submitting the WIP series. >> As to where to host the project, the obvious choice is perhaps a >> project at sourceware, but it would be nice if we could develop the >> front-end in a branch in the GCC git repo > > (You're now using > <https://forge.sourceware.org/jemarch/a68-gcc/src/branch/a68>.) > >> to have a mailing list >> under gcc.gnu.org > > Yes. Once the front end is accepted into GCC, I suggest you request > <algo...@gcc.gnu.org>. (That's probably more expressive than > <a...@gcc.gnu.org>?) Sounds good. >> and to use a page in the GCC wiki to track the FE >> progress... please let me know if that is feasible. > > (You've already set up <https://gcc.gnu.org/wiki/Algol68FrontEnd>.) > > > Grüße > Thomas
