On Tue, Jul 24, 2012 at 7:13 PM, Steven Bosscher <stevenb....@gmail.com> wrote: >> AFAIR the qsort is just for getting a stable ordering over two pools to find >> the leaked regsets afterwards, the type of ordering doesn't matter. > > What matters is that the compare function gives a reliable result. You > can't subtract pointers like that for qsort. > > After consulting the experts on IRC, I'm going with a fix along the > lines of "return (x == y ? 0 : (x < y ? -1 : 1));". > >> Anyways, >> how come this is related to your patch? We don't use statistics in >> sel-sched... Something got miscompiled? > > No, just allocated slightly differently. A bitmap_head is one pointer > bigger than before. I'm unsure how that causes this problem, though. I > suspect you would have seen the same failure with GATHER_STATISTICS > enabled.
Oh, bigger bitmap_head? That's bad ... :/ So much for '#ifdefs are bad' :/ Richard. > Ciao! > Steven
