On Wed, Feb 05, 2025 at 12:59:58PM +0100, Jakub Jelinek wrote:
> > > +            if (warn_cxx_compat || len - unit > avail)
> > > +              {
> > > +                 pedwarn_init (init_loc, 0,
> > > +                               ("initializer-string for array of %qT "
> > > +                                "is too long (%lu chars into %lu "
> > > +                                "available)"), typ1, len, avail);
> > > +              }
> > 
> > No need for the { } here.
> 
> The indentation is wrong in the whole block.
> The { after compare_tree_int is indented by 2 tabs (so 16 columns), but
> unsigned HOST_WIDE_INT avail already by 2 tabs and 3 spaces rather than
> 2 tabs and 2 spaces.  So it is one column more right than it should be.

And still talking about the formatting, the ()s around the format string
are unnecessary, we don't really use it anywhere else even when the
format string is too long and needs to be split.
I know in this case it was preexisting, but should be fixed when changed.

        Jakub

Reply via email to