On Tue, Jul 24, 2012 at 3:18 AM, Uros Bizjak <ubiz...@gmail.com> wrote:
>
> On Mon, Jul 23, 2012 at 10:17 PM, Teresa Johnson <tejohn...@google.com> wrote:
> > Resending in plain text mode so it goes through.
> > Teresa
> >
> > On Mon, Jul 23, 2012 at 12:03 PM, Teresa Johnson <tejohn...@google.com> 
> > wrote:
> >> Any possibility of getting these patches (186979 and 186993), along with
> >> r184891 (which added the and->zext splitter), backported to the 4_7 branch?
> >> I found a performance issue where "andw $0xff, %reg" was not being 
> >> converted
> >> to movzbl when the source and target registers are the same, resulting in
> >> LCP stalls, which is fixed by this series of patches.
>
> These looks too risky, especially r184891. I have waited with this
> patch after 4.7 branched just because of this risk factor.


Ok, I will plan to port these directly to the google branches then.

>
>
> BTW: This part was wrong, there is no xmm->xmm movq insn:
>
>         (*zero_extendsidi2_rex64): Add x,x alternative.
>         (*zero_extendsidi2): Ditto.


Yes, it looks like I need these 3:

------------------------------------------------------------------------
r188648 | uros | 2012-06-14 23:53:28 -0700 (Thu, 14 Jun 2012) | 3 lines
Changed paths:
   M /trunk/gcc/ChangeLog
   M /trunk/gcc/config/i386/i386.md

        (*zero_extendsidi2_rex64): Remove isa attribute.


------------------------------------------------------------------------
r188634 | uros | 2012-06-14 12:38:12 -0700 (Thu, 14 Jun 2012) | 6 lines
Changed paths:
   M /trunk/gcc/ChangeLog
   M /trunk/gcc/config/i386/i386.md

Fix my previous commit to:

        * config/i386/i386.md (*zero_extendsidi2): Remove x,x alternative.
        (*zero_extendsidi2_rex64): Ditto.


------------------------------------------------------------------------
r188630 | uros | 2012-06-14 11:51:36 -0700 (Thu, 14 Jun 2012) | 5 lines
Changed paths:
   M /trunk/gcc/ChangeLog
   M /trunk/gcc/config/i386/i386.md

        * config/i386/i386.md (*zero_extendsidi2): Mark movd alternatives
        SSE2 only.  Remove x,x alternative.
------------------------------------------------------------------------


Thanks,
Teresa

>
> Uros.




--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Reply via email to