Hi Robin, Sure, I will do everything you listed shortly, and I will apply a second version of the patch.
Regards, Yuriy Kolerov Regards, Yuriy Kolerov ________________________________ From: Robin Dapp <rdapp....@gmail.com> Sent: Monday, January 20, 2025 4:02:36 PM To: Yuriy Kolerov <ykole...@synopsys.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org> Cc: Artemiy Volkov <arte...@synopsys.com>; Robin Dapp <rdapp....@gmail.com> Subject: Re: [PATCH] RISC-V: Fix a typo in zce to zcf implication > zce must imply zcf but this rule was corrupted after > refactoring in this commit: > > 9e12010b5e724277ea44c300630802f464407d8d > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc: fix zce to zcf > implication. Thanks, looks reasonable but please add a test case as it's clearly a regression. Ideally open a bug as well and reference the PR. Also, please specify how and what you tested. -- Regards Robin