Kewen:
Thanks for the approval. Sorry for the delay in getting this
committed. I made the fix requested and retested the patch on the most
recent mainline. I will get this committed. Thanks for all the help.
Carl
On 11/24/24 5:42 AM, Kewen Lin wrote:
rs6000, fix test builtins-1-p10-runnable.c
The test has two issues:
1) The test should generate execute abort() if an error is found.
However, the test contains a #define 0 which actually enables the
error prints not exectuting void() because the debug code is protected
by an #ifdef not #if. The #define DEBUG needs to be removed to so the
test will abort on an error.
2) The vec_i_expected output was tweeked to test that it would fail.
The test value was not removed.
By removing the #define DEBUG, the test fails and reports 1 failure.
Removing the intentionally wrong expected value results in the test
passing with no errors as expected.
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/builtins-1-p10-runnable.c: Remove #define
DEBUG. Replace vec_i_expected value with correct value.
Nit: Three more spaces before "Replace", so s/ //.
OK for trunk with this tweaked, thanks!
BR,
