Tamar Christina <tamar.christ...@arm.com> writes: >> -----Original Message----- >> From: Wilco Dijkstra <wilco.dijks...@arm.com> >> Sent: Tuesday, January 14, 2025 5:30 PM >> To: Richard Sandiford <richard.sandif...@arm.com> >> Cc: Richard Earnshaw <richard.earns...@arm.com>; ktkac...@nvidia.com; GCC >> Patches <gcc-patches@gcc.gnu.org>; sch...@linux-m68k.org >> Subject: Re: [PATCH] AArch64: Deprecate -mabi=ilp32 >> >> Hi Richard, >> >> >> + if (TARGET_ILP32) >> >> + warning (OPT_Wdeprecated, "%<-mabi=ilp32%> is deprecated."); >> > >> > There should be no "." at the end of the message. >> >> Right, fixed in v2 below. >> >> > Otherwise it looks good to me, although like Kyrill says, it'll also >> > need a release note. >> >> I've added one, see https://gcc.gnu.org/pipermail/gcc-patches/2025- >> January/673575.html >> >> > Please give others 24 hours to comment. Otherwise the patch is OK >> > with that change. >> >> Sure. >> >> > (I saw Andreas's comment about starting sentences with a lowercase >> > letter, but IMO that's ok for program text.) >> >> I changed it to "The @samp{ilp32} model is deprecated." (using "option" felt >> wrong here). >> >> Cheers, >> Wilco >> >> >> v2: Update after review >> >> ILP32 was originally intended to make porting to AArch64 easier. Support was >> never merged in the Linux kernel or GLIBC, so it has been unsupported for >> many >> years. There isn't a benefit in keeping unsupported features forever, so >> deprecate it now (and it could be removed in a future release). >> >> Passes regress & bootstrap, OK for commit? > > Hi, > > This patch seems to break embedded builds as on -elf platforms we build ilp32 > as > a default multilib variant. > > That is in gcc/config.gcc > > aarch64*-*-elf | aarch64*-*-fuchsia* | aarch64*-*-rtems* > > all do: > > aarch64_multilibs="${with_multilib_list}" > if test "$aarch64_multilibs" = "default"; then > aarch64_multilibs="lp64,ilp32" > fi > > Which then fails the build because of -Werror. > > So the question is as the discussion above has been about Linux, should the > deprecation just be on Linux or also ELF, and if ELF should we remove it from > the default multilib?
FWIW, my vote would be for removing the multilib. Thanks, Richard
