Hi Richard, > It looks like you committed the original version instead, with no extra > explanation. I suppose I should have asked for another review round > instead.
Did you check the commit log? Change the AARCH64_EXPAND_ALIGNMENT macro into proper function calls to make future changes easier. Use the existing alignment settings, however avoid overaligning small array's or structs to 64 bits when there is no benefit. The lower alignment gives a small reduction in data and stack size. Using 32-bit alignment for small char arrays still improves performance of string functions since it can be loaded in full by the first 8/16-byte load. That should be enough without it becoming a tutorial on how to align data for performance... Cheers, Wilco