On Wed, 2025-01-08 at 07:48 -0800, Andi Kleen wrote: > > I wanted to ping this patch series. Thanks. > > -Andi >
Thanks for tha patches, and sorry about not getting back to you earlier (I've been focusing on analyzing many 100s of build failures with GCC 15 relative to GCC 14) Overall, the patches look like they *might* be OK, but: * were these tested these on top of r15-6284-g778336e0e4f257? (in which I added a new feature to file_cache to help with sarif-replay) * I haven't yet fully grokked the patches, especially the one that changes the line cache eviction mechanism (so maybe the following is overly paranoid...) * I'm nervous about landing a big change to this at this point in the GCC 15 cycle; is there a way to add test coverage e.g. with more selftests in input.cc to try to exercise the various cases in the code (or to just brute force it!); see e.g. test_reading_source_line; we could have a selftest write out files with various numbers of lines and try various patterns of line number access, perhaps. * I've been working to reduce global state in the diagnostics subsystem: e.g. in libgdiagnostics there can be multiple diagnostic contexts, each with their own file cache. Is there a way to make the line_record_size and num_files be member data of their classes, i.e. if the previously "static const" things didn't just lose their "const", but also lost their "static"? That could help with unit-testing the code. That said I see in patch 6 of the kit that perhaps there are interactions here that need taking care of. Sorry not to have a full review yet Dave
