David Malcolm <dmalc...@redhat.com> writes: > On Thu, 2025-01-02 at 18:33 +0000, Joseph Myers wrote: >> On Thu, 19 Dec 2024, David Malcolm wrote: >> >> > Here's an updated version of the patch. >> > >> > Changed in v2: >> > - distinguish between "bool" and "_Bool" when determining >> > standard version >> > - more test coverage >> > >> > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. >> > OK for trunk? >> >> OK. > > Thanks; pushed as r15-6507-g321983033d621e. > >> (I'm guessing the other new keywords that weren't previously >> reserved >> (alignas, alignof, constexpr, nullptr, static_assert, thread_local, >> typeof, typeof_unqual) are sufficiently rare as identifiers that they >> aren't worth trying to produce better diagnostics for.) > > That was my thinking too. > > Sam, did you see anything significant here in your testing?
Honestly, they've barely come up. Out of the ones which *have*, it's static_assert and nullptr. The others either never or once. nullptr: https://bugs.gentoo.org/944747 static_assert: binutils, git iirc It's fine with me if we wait-and-see. I'll keep an eye out for other classes of C23 issues as well. Thanks again for these > > Thanks > Dave cheers, sam
