Hi Paul,
thanks for the quick review. Pushed as gcc-15-6425-gdae506f73bd
Thanks again,
Andre
On Mon, 23 Dec 2024 15:13:50 +0000
Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote:
> Hi Andre,
>
> It looks good to me.
>
> Thanks
>
> Paul
>
>
> On Mon, 23 Dec 2024 at 14:58, Andre Vehreschild <ve...@gmx.de> wrote:
>
> > Hi all,
> >
> > I did an ooppsie with the patch for 107635. Attached is a patch that fixes
> > this. Essentially the regexp was to complicated for what was needed. So
> > now we
> > just count the number of occurrences of caf_get_by_ct, which has to be
> > four.
> >
> > Regtests ok on x86_64-pc-linux-gnu. Ok for mainline?
> >
> > Regards,
> > Andre
> >
> > On Mon, 23 Dec 2024 04:52:50 +0800
> > "haochen.jiang" <haoch...@smtp.intel.com> wrote:
> >
> > > On Linux/x86_64,
> > >
> > > 586477d67bf2e320e8ec41f82b194259c1dcc43a is the first bad commit
> > > commit 586477d67bf2e320e8ec41f82b194259c1dcc43a
> > > Author: Andre Vehreschild <ve...@gcc.gnu.org>
> > > Date: Fri Dec 6 08:57:34 2024 +0100
> > >
> > > Fortran: Replace getting of coarray data with accessor-based version.
> > > [PR107635]
> > >
> > > caused
> > >
> > > FAIL: gfortran.dg/coarray_lib_comm_1.f90 -O0 scan-tree-dump-times
> > > original "_gfortran_caf_get_by_ct \\(caf_token.., 0B, 0B, 1, \\(unsigned
> > > long\\) atmp.[0-9]+.span" 4 FAIL: gfortran.dg/coarray_lib_comm_1.f90
> > -O1
> > > scan-tree-dump-times original "_gfortran_caf_get_by_ct \\(caf_token..,
> > 0B,
> > > 0B, 1, \\(unsigned long\\) atmp.[0-9]+.span" 4 FAIL:
> > > gfortran.dg/coarray_lib_comm_1.f90 -O2 scan-tree-dump-times original
> > > "_gfortran_caf_get_by_ct \\(caf_token.., 0B, 0B, 1, \\(unsigned long\\)
> > > atmp.[0-9]+.span" 4 FAIL: gfortran.dg/coarray_lib_comm_1.f90 -O3
> > > -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer
> > -finline-functions
> > > scan-tree-dump-times original "_gfortran_caf_get_by_ct \\(caf_token..,
> > 0B,
> > > 0B, 1, \\(unsigned long\\) atmp.[0-9]+.span" 4 FAIL:
> > > gfortran.dg/coarray_lib_comm_1.f90 -O3 -g scan-tree-dump-times
> > original
> > > "_gfortran_caf_get_by_ct \\(caf_token.., 0B, 0B, 1, \\(unsigned long\\)
> > > atmp.[0-9]+.span" 4 FAIL: gfortran.dg/coarray_lib_comm_1.f90 -Os
> > > scan-tree-dump-times original "_gfortran_caf_get_by_ct \\(caf_token..,
> > 0B,
> > > 0B, 1, \\(unsigned long\\) atmp.[0-9]+.span" 4
> > >
> > > with GCC configured with
> > >
> > > ../../gcc/configure
> > > --prefix=/export/users/haochenj/src/gcc-bisect/master/master/r15-6415/usr
> > > --enable-clocale=gnu --with-system-zlib --with-demangler-in-ld
> > > --with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet
> > --without-isl
> > > --enable-libmpx x86_64-linux --disable-bootstrap
> > >
> > > To reproduce:
> > >
> > > $ cd {build_dir}/gcc && make check
> > > RUNTESTFLAGS="dg.exp=gfortran.dg/coarray_lib_comm_1.f90
> > > --target_board='unix{-m32}'" $ cd {build_dir}/gcc && make check
> > > RUNTESTFLAGS="dg.exp=gfortran.dg/coarray_lib_comm_1.f90
> > > --target_board='unix{-m32\ -march=cascadelake}'"
> > >
> > > (Please do not reply to this email, for question about this report,
> > contact
> > > me at haochen dot jiang at intel.com.) (If you met problems with
> > cascadelake
> > > related, disabling AVX512F in command line might save that.) (However,
> > please
> > > make sure that there is no potential problems with AVX512.)
> >
> >
> > --
> > Andre Vehreschild * Email: vehre ad gmx dot de
> >
--
Andre Vehreschild * Email: vehre ad gmx dot de
