On 18/12/2024 18:45, Torbjörn SVENSSON wrote:
> Changes since v1:
>
> - Split tests into two parts. One part for doing asm checkes. Another part
> for doing run test as these require hardware to be available.
> - Changed existing tests to be "compile" instead of "run".
>
> Changes since v2:
>
> - Applied the same fix to memset-inline-8.c and memset-inline-9.c since
> they also fail for the same reason.
>
> Ok for trunk and releases/gcc-14?
>
> --
>
> Split tests into 2 parts:
> - The first part checkes the assmbler generated.
> - The second part does the run test and this part now requires
> effective-target arm_neon_hw.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/memset-inline-4.c: Only check assembler output.
> * gcc.target/arm/memset-inline-5.c: Likewise.
> * gcc.target/arm/memset-inline-6.c: Likewise.
> * gcc.target/arm/memset-inline-8.c: Likewise.
> * gcc.target/arm/memset-inline-9.c: Likewise.
> * gcc.target/arm/memset-inline-4-exe.c: New test.
> * gcc.target/arm/memset-inline-5-exe.c: Likewise.
> * gcc.target/arm/memset-inline-6-exe.c: Likewise.
> * gcc.target/arm/memset-inline-8-exe.c: Likewise.
> * gcc.target/arm/memset-inline-9-exe.c: Likewise.
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svens...@foss.st.com>
OK.
R.
> ---
> gcc/testsuite/gcc.target/arm/memset-inline-4-exe.c | 7 +++++++
> gcc/testsuite/gcc.target/arm/memset-inline-4.c | 2 +-
> gcc/testsuite/gcc.target/arm/memset-inline-5-exe.c | 7 +++++++
> gcc/testsuite/gcc.target/arm/memset-inline-5.c | 2 +-
> gcc/testsuite/gcc.target/arm/memset-inline-6-exe.c | 7 +++++++
> gcc/testsuite/gcc.target/arm/memset-inline-6.c | 2 +-
> gcc/testsuite/gcc.target/arm/memset-inline-8-exe.c | 7 +++++++
> gcc/testsuite/gcc.target/arm/memset-inline-8.c | 2 +-
> gcc/testsuite/gcc.target/arm/memset-inline-9-exe.c | 7 +++++++
> gcc/testsuite/gcc.target/arm/memset-inline-9.c | 2 +-
> 10 files changed, 40 insertions(+), 5 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/arm/memset-inline-4-exe.c
> create mode 100644 gcc/testsuite/gcc.target/arm/memset-inline-5-exe.c
> create mode 100644 gcc/testsuite/gcc.target/arm/memset-inline-6-exe.c
> create mode 100644 gcc/testsuite/gcc.target/arm/memset-inline-8-exe.c
> create mode 100644 gcc/testsuite/gcc.target/arm/memset-inline-9-exe.c
>
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-4-exe.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-4-exe.c
> new file mode 100644
> index 00000000000..fef6c4365e2
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-4-exe.c
> @@ -0,0 +1,7 @@
> +/* { dg-do run } */
> +/* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> +/* { dg-require-effective-target arm_neon_hw } */
> +/* { dg-options "-save-temps -O2 -fno-inline" } */
> +/* { dg-add-options "arm_neon" } */
> +
> +#include "./memset-inline-4.c"
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-4.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-4.c
> index 5d7223ef2c0..6eb2a9d18a3 100644
> --- a/gcc/testsuite/gcc.target/arm/memset-inline-4.c
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-4.c
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do compile } */
> /* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> /* { dg-options "-save-temps -O2 -fno-inline" } */
> /* { dg-add-options "arm_neon" } */
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-5-exe.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-5-exe.c
> new file mode 100644
> index 00000000000..a52a527ea13
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-5-exe.c
> @@ -0,0 +1,7 @@
> +/* { dg-do run } */
> +/* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> +/* { dg-require-effective-target arm_neon_hw } */
> +/* { dg-options "-save-temps -O2 -fno-inline" } */
> +/* { dg-add-options "arm_neon" } */
> +
> +#include "./memset-inline-5.c"
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-5.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-5.c
> index 6e7ae65eef4..0f55c7b8c88 100644
> --- a/gcc/testsuite/gcc.target/arm/memset-inline-5.c
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-5.c
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do compile } */
> /* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> /* { dg-options "-save-temps -O2 -fno-inline" } */
> /* { dg-add-options "arm_neon" } */
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-6-exe.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-6-exe.c
> new file mode 100644
> index 00000000000..8e58d681023
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-6-exe.c
> @@ -0,0 +1,7 @@
> +/* { dg-do run } */
> +/* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> +/* { dg-require-effective-target arm_neon_hw } */
> +/* { dg-options "-save-temps -O2 -fno-inline" } */
> +/* { dg-add-options "arm_neon" } */
> +
> +#include "./memset-inline-6.c"
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-6.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-6.c
> index ae226346d48..49ed68cbf35 100644
> --- a/gcc/testsuite/gcc.target/arm/memset-inline-6.c
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-6.c
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do compile } */
> /* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> /* { dg-options "-save-temps -O2 -fno-inline" } */
> /* { dg-add-options "arm_neon" } */
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-8-exe.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-8-exe.c
> new file mode 100644
> index 00000000000..0ff1f6cbe89
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-8-exe.c
> @@ -0,0 +1,7 @@
> +/* { dg-do run } */
> +/* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> +/* { dg-require-effective-target arm_neon_hw } */
> +/* { dg-options "-save-temps -O2 -fno-inline" } */
> +/* { dg-add-options "arm_neon" } */
> +
> +#include "./memset-inline-8.c"
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-8.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-8.c
> index bcfe6404efa..e12e9330f75 100644
> --- a/gcc/testsuite/gcc.target/arm/memset-inline-8.c
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-8.c
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do compile } */
> /* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> /* { dg-options "-save-temps -O2 -fno-inline" } */
> /* { dg-add-options "arm_neon" } */
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-9-exe.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-9-exe.c
> new file mode 100644
> index 00000000000..eb1e61857aa
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-9-exe.c
> @@ -0,0 +1,7 @@
> +/* { dg-do run } */
> +/* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> +/* { dg-require-effective-target arm_neon_hw } */
> +/* { dg-options "-save-temps -Os -fno-inline" } */
> +/* { dg-add-options "arm_neon" } */
> +
> +#include "./memset-inline-9.c"
> diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-9.c
> b/gcc/testsuite/gcc.target/arm/memset-inline-9.c
> index d9e0722f732..34e328028d5 100644
> --- a/gcc/testsuite/gcc.target/arm/memset-inline-9.c
> +++ b/gcc/testsuite/gcc.target/arm/memset-inline-9.c
> @@ -1,4 +1,4 @@
> -/* { dg-do run } */
> +/* { dg-do compile } */
> /* { dg-skip-if "Don't inline memset using neon instructions" { !
> arm_tune_string_ops_prefer_neon } } */
> /* { dg-options "-save-temps -Os -fno-inline" } */
> /* { dg-add-options "arm_neon" } */
