On Thu, 12 Dec 2024, James K. Lowden wrote:

> +    static char name[PATH_MAX];

Static buffers with a PATH_MAX size will probably break the build on Hurd 
host.

> +__int128  get_power_of_ten(int n);

GCC supports 32-bit hosts; you shouldn't rely on __int128 being available 
on the host.

> +extern "C" __int128 __gg__binary_value_from_qualified_field(int        
> *rdigits,
> +                                                            cblc_field_t 
> *var,
> +                                                            size_t     
> offset,
> +                                                            size_t     size);
> +extern "C"  _Float128 __gg__float128_from_qualified_field(cblc_field_t 
> *field,
> +                                                          size_t offset,
> +                                                          size_t size);

I'm not entirely sure whether this is host or target code (you always need 
to be clear about which is which in GCC), but in any case, both hosts and 
targets without __int128 or _Float128 are supported in GCC.

In general, target code - including headers - should not go under gcc/ at 
all.  And host code shouldn't be using __* identifiers as those are 
reserved.

-- 
Joseph S. Myers
josmy...@redhat.com

Reply via email to