On Sat, Dec 7, 2024 at 5:22 PM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 12/7/24 8:38 AM, Jason Merrill wrote: > > On 12/6/24 7:37 AM, Richard Biener wrote: > >> On Wed, Dec 4, 2024 at 9:48 PM H.J. Lu <hjl.to...@gmail.com> wrote: > >>> > >>> Remove the targetm.calls.promote_prototypes call from C, C++ and Ada > >>> frontends. > >> > >> I'm conditionally approving this unless FE maintainers complain before > >> holidays > >> (the effect of the hook is re-instantiated during RTL expansion in 1/7). > >> > >> I've added the FE maintainers to CC > > > > I'm not entirely clear why this patch series isn't an ABI break, but > > trust you to have considered that. I have no C++-specific objection. > That's my generic concern anytime we change these code paths. > > I Richi's position would be that the promote_prototypes call being used > by the front-ends is fundamenally broken and I would generally agree. > In theory the actions it's taking are supposed to be addressed by a > later patch in the series.
Let me add that targetm.calls.promote_prototypes is _not_ part of the ABI. Even when we'd drop it entirely this shouldn't have any effect -- unless there are targets who fail to implement TARGET_PROMOTE_FUNCTION_MODE and friends correctly. That said, the first patch in the series ensures TARGET_PROMOTE_PROTOTYPES is applied later during RTL expansion (where also TARGET_PROMOTE_FUNCTION_MODE is applied). Richard. > > Jeff > >
