On Wed, Dec 4, 2024 at 1:28 PM Jonathan Wakely <jwak...@redhat.com> wrote: > > On Wed, 4 Dec 2024 at 20:43, Vineet Gupta <vine...@rivosinc.com> wrote: > > > > On 12/4/24 11:48, Jonathan Wakely wrote: > > >> gcc/ChangeLog: > > >> PR target/11472 > > > Note that you typo'd the PR number here, so that it added a comment > > > to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=11472 > > > > Apologies my bad. > > > > In my defense I ran following: > > > > ./contrib/gcc-changelog/git_check_commit.py > > Yes, it seems this script doesn't notice this problem. It will > complain if the summary line has [PRnnn] and the ChangeLog part > doesn't have a matching PR, but apparently it doesn't complain the > other way around. > Or maybe it didn't complain because the ChangeLog part contained > *both* PR target/114729 and PR target/11472, and so the PR/114729 in > the summary did match something in the ChangeLog part.
Yes it only sees if the summary has a reference to bug #, it is in the changelog too and not if there is one in the changelog, there is also one in the summary. In this case since there is one in the summary, it matches against the one in the changelog; but it does not check the others. This is because sometimes you have a few different PRs but there is a main PR # in the summary. One thing that is useful is just placing the PR # reference before the full changelog instead of inside each one. This reduces the change of a typo (though not all the way). Thanks, Andrew Pinski > > > > ./contrib/check_GNU_style.sh > > > > > > > The server-side git hooks that check commit logs didn't notice it, > > > because you used [PR/114729] in the subject line, which should be in > > > the form [PR114729]. If you'd used the correct form, the hooks would > > > have told you that the two PR numbers didn't match. > > > > > > I see you've been using the PR/nnn form for all your commits, please > > > use the [PRnnn] form as described at > > > https://gcc.gnu.org/contribute.html#patches > > > > Alright I'll do this going fwd. > > > > Thx, > > -Vineet > > >
