On 9/18/24 4:36 PM, Arsen Arsenović wrote:
This provides to people working on coroutines, as well as writing tests
for coroutines, a way to have insight into the results and inputs of the
coroutine transformation passes, which is quite essential to
understanding what happens in the coroutine transformation. Currently,
the information dumped is the pre-transform function (which is not
otherwise available), the generated ramp function, the generated frame
type, the transformed actor/resumer, and the destroyer stub.
While debugging this, I've also encountered a minor bug in
c-pretty-print.cc, where it tried to check DECL_REGISTER of DECLs that
did not support it. I've added a check for that.
Similary, I found one in pp_cxx_template_parameter, where TREE_TYPE was
called on the list cell the template parameter was in rather than on the
parameter itself. I've fixed that.
And, lastly, there appeared to be no way to pretty-print a FIELD_DECL,
so I added support to cxx_pretty_printer::declaration for it (by reusing
the VAR_DECL path).
Co-authored-by: Iain Sandoe <i...@sandoe.co.uk>
(coro_maybe_dump_transformed_functions): New. Prints the actor
and destroy functions passed to it, if dumping is enabled, as
well as the frame type (inferred from the actor argument).
For future reference, this sort of description belongs in comments, not
the ChangeLog; just "New." is enough.
+/* ================= Debug. ================= */
+
+#include "langhooks.h"
+#include "cxx-pretty-print.h"
Missing function comment.
+static void
+dump_record_fields (cxx_pretty_printer *pp, tree typ)
...
+/* For a given ACTOR, DESTROY and FRAME_TYPE, if lang-coro dumping is enabled,
+ pretty-print their contents to the lang-coro dump. */
+static void
+coro_maybe_dump_transformed_functions (tree actor, tree destroy)
Seems like FRAME_TYPE isn't a parameter anymore.
OK with those comment fixes.
Jason
