On Wed, 20 Nov 2024, Feng Wang wrote:

> This patch fix the wrong condition for RVVMF2BF. It should be
> TARGET_VECTOR_ELEN_BF_16.
> gcc/ChangeLog:
> 
>       PR target/117669
>       * config/riscv/vector-iterators.md:
> 
> Signed-off-by: Feng Wang <wangf...@eswincomputing.com>

There's missing text after the ":", where one would expect the 
line to be something like:

        * config/riscv/vector-iterators.md (RVVMF2BF): Correct condition.

Too late to fix now as the approval and commit was quick, but 
please *edit* the result of contrib/mklog.py, it's not final.  
The commit checker is known to have unfortunate flaws.  (Can't 
rule out an ":" at the end of a line, it is sometimes valid.)

brgds, H-P

> ---
>  gcc/config/riscv/vector-iterators.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/riscv/vector-iterators.md 
> b/gcc/config/riscv/vector-iterators.md
> index 6a621459cc4..92cb651ce49 100644
> --- a/gcc/config/riscv/vector-iterators.md
> +++ b/gcc/config/riscv/vector-iterators.md
> @@ -365,7 +365,7 @@
>  
>    (RVVM2BF "TARGET_VECTOR_ELEN_BF_16")
>    (RVVM1BF "TARGET_VECTOR_ELEN_BF_16")
> -  (RVVMF2BF "TARGET_VECTOR_ELEN_FP_16")
> +  (RVVMF2BF "TARGET_VECTOR_ELEN_BF_16")
>    (RVVMF4BF "TARGET_VECTOR_ELEN_BF_16 && TARGET_MIN_VLEN > 32 && 
> TARGET_64BIT")
>  
>    (RVVM2HF "TARGET_VECTOR_ELEN_FP_16 && TARGET_64BIT")
> -- 
> 2.17.1
> 
> 

Reply via email to