Hi Christophe,
On 28/11/2024 17:00, Christophe Lyon wrote:
Hi Andre,
Thanks, the patch LGTM except a minor nit:
/* Using a VPR that gets re-generated within the loop. */
-void test10 (int32_t *a, int32_t *b, int32_t *c, int n)
+void test10a (int32_t *a, int32_t *b, int32_t *c, int n)
[...]
+/* Using a VPR that gets re-generated within the loop. */
+void test10b (int32_t *a, int32_t *b, int32_t *c, int n)
Can you update the comment before test10b, to highlight the difference
with test10a?
Thanks,
Christophe
I just sent a patch series and patch 3 of that series titled:
arm, mve: Detect uses of vctp_vpr_generated inside subregs
Has a better fix for this issue, less of a hammer. It addresses a
short-coming in the dlstp analysis where a rtx_equal_p was being used on
DF_REF_REG of INSN_USE's to detect uses of vctp_vpr_generated, but that
doesn't work if the USE is in a subreg, whereas the suggestion is to use
reg_overlap_mentioned_p. That enables the existing analysis to block the
loops that were causing the issue that this patch was trying to address
with a 'bigger hammer'.
So dropping this patch in favour of the new one, and I just realized I
didn't address the comments on the testcase that the other patch shares
with this... will do that!
