I don't see any regressions with this change. Patch is okay if you remove declaration of pa_section_type_flags in pa.cc.
Dave
On Thu, Nov 21, 2024 at 09:04:52PM +0800, Xi Ruoyao wrote:
> It's no longer needed since r15-4842 (when the target-independent code
> started to handle the case).
>
> gcc/ChangeLog:
>
> * config/pa/pa.cc (pa_section_type_flags): Remove.
> (TARGET_SECTION_TYPE_FLAGS): Remove.
> ---
>
> I don't have a hppa machine to test this, but conceptually this should
> be correct. Ok for trunk?
>
> gcc/config/pa/pa.cc | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/gcc/config/pa/pa.cc b/gcc/config/pa/pa.cc
> index 94ee7dbfa8e..783b922a5fc 100644
> --- a/gcc/config/pa/pa.cc
> +++ b/gcc/config/pa/pa.cc
> @@ -407,8 +407,6 @@ static size_t n_deferred_plabels = 0;
>
> #undef TARGET_LEGITIMATE_CONSTANT_P
> #define TARGET_LEGITIMATE_CONSTANT_P pa_legitimate_constant_p
> -#undef TARGET_SECTION_TYPE_FLAGS
> -#define TARGET_SECTION_TYPE_FLAGS pa_section_type_flags
> #undef TARGET_LEGITIMATE_ADDRESS_P
> #define TARGET_LEGITIMATE_ADDRESS_P pa_legitimate_address_p
>
> @@ -10900,25 +10898,6 @@ pa_legitimate_constant_p (machine_mode mode, rtx x)
> return true;
> }
>
> -/* Implement TARGET_SECTION_TYPE_FLAGS. */
> -
> -static unsigned int
> -pa_section_type_flags (tree decl, const char *name, int reloc)
> -{
> - unsigned int flags;
> -
> - flags = default_section_type_flags (decl, name, reloc);
> -
> - /* Function labels are placed in the constant pool. This can
> - cause a section conflict if decls are put in ".data.rel.ro"
> - or ".data.rel.ro.local" using the __attribute__ construct. */
> - if (strcmp (name, ".data.rel.ro") == 0
> - || strcmp (name, ".data.rel.ro.local") == 0)
> - flags |= SECTION_WRITE | SECTION_RELRO;
> -
> - return flags;
> -}
> -
> /* pa_legitimate_address_p recognizes an RTL expression that is a
> valid memory address for an instruction. The MODE argument is the
> machine mode for the MEM expression that wants to use this address.
> --
> 2.47.0
>
signature.asc
Description: PGP signature
