Hi Jakub,

在 2024/11/22 16:18, Jakub Jelinek 写道:
> Hi!
> 
> These tests use the K&R function style definitions or pass arguments
> to () functions.
> It seemed easiest to just use -std=gnu17 for all of those.

Thanks for fixing!  I slightly prefer passing -Wno-old-style-definition
instead as the test cases can still go with the default c dialect.  But
it's your call. :)  OK for trunk with or without that change.  Thanks!

BR,
Kewen

> 
> Bootstrapped/regtested on powerpc64le-linux and powerpc64-linux (on the
> latter tested with -m32/-m64), ok for trunk?
> 
> 2024-11-22  Jakub Jelinek  <ja...@redhat.com>
> 
>       PR testsuite/117663
>       * gcc.target/powerpc/pr58673-1.c: Add -std=gnu17 to dg-options.
>       * gcc.target/powerpc/pr64505.c: Likewise.
>       * gcc.target/powerpc/pr116170.c: Likewise.
>       * gcc.target/powerpc/pr58673-2.c: Likewise.
>       * gcc.target/powerpc/pr64019.c: Likewise.
>       * gcc.target/powerpc/pr96506-1.c: Likewise.
>       * gcc.target/powerpc/swaps-stack-protector.c: Likewise.
>       * gcc.target/powerpc/pr78543.c: Likewise.
>       * gcc.dg/vect/pr48765.c: Add -std=gnu17 to dg-additional-options.
> 
> --- gcc/testsuite/gcc.target/powerpc/pr58673-1.c.jj   2024-06-04 
> 13:19:04.531594020 +0200
> +++ gcc/testsuite/gcc.target/powerpc/pr58673-1.c      2024-11-21 
> 18:57:26.724287696 +0100
> @@ -1,6 +1,6 @@
>  /* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
>  /* { dg-skip-if "" { powerpc*-*-darwin* } } */
> -/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O1" } */
> +/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O1 -std=gnu17" } */
>  /* { dg-require-effective-target powerpc_vsx } */
>  
>  enum typecode
> --- gcc/testsuite/gcc.target/powerpc/pr64505.c.jj     2020-11-09 
> 15:25:52.000000000 +0100
> +++ gcc/testsuite/gcc.target/powerpc/pr64505.c        2024-11-21 
> 19:08:32.258800032 +0100
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-skip-if "" { powerpc*-*-aix* } } */
> -/* { dg-options "-w -O2 -mpowerpc64" } */
> +/* { dg-options "-w -O2 -mpowerpc64 -std=gnu17" } */
>  
>  /*
>   * (below is minimized test case)
> --- gcc/testsuite/gcc.target/powerpc/pr116170.c.jj    2024-11-21 
> 18:56:42.283921230 +0100
> +++ gcc/testsuite/gcc.target/powerpc/pr116170.c       2024-11-21 
> 18:55:57.301562478 +0100
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target ppc_float128_sw } */
> -/* { dg-options "-mdejagnu-cpu=power8 -O2 -fstack-protector-strong 
> -ffloat-store" } */
> +/* { dg-options "-mdejagnu-cpu=power8 -O2 -fstack-protector-strong 
> -ffloat-store -std=gnu17" } */
>  
>  /* Verify there is no ICE.  */
>  
> --- gcc/testsuite/gcc.target/powerpc/pr58673-2.c.jj   2024-06-04 
> 13:19:04.531594020 +0200
> +++ gcc/testsuite/gcc.target/powerpc/pr58673-2.c      2024-11-21 
> 18:59:33.549479716 +0100
> @@ -1,6 +1,6 @@
>  /* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
>  /* { dg-skip-if "" { powerpc*-*-darwin* } } */
> -/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3 -funroll-loops" } */
> +/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3 -funroll-loops -std=gnu17" } 
> */
>  /* { dg-require-effective-target powerpc_vsx } */
>  
>  #include <stddef.h>
> --- gcc/testsuite/gcc.target/powerpc/pr64019.c.jj     2024-06-04 
> 13:19:04.531594020 +0200
> +++ gcc/testsuite/gcc.target/powerpc/pr64019.c        2024-11-21 
> 19:00:08.110987010 +0100
> @@ -1,6 +1,6 @@
>  /* { dg-do compile { target { powerpc*-*-* } } } */
>  /* { dg-skip-if "" { powerpc*-*-darwin* } } */
> -/* { dg-options "-O2 -ffast-math -mdejagnu-cpu=power7" } */
> +/* { dg-options "-O2 -ffast-math -mdejagnu-cpu=power7 -std=gnu17" } */
>  /* { dg-require-effective-target powerpc_vsx } */
>  
>  #include <math.h>
> --- gcc/testsuite/gcc.target/powerpc/pr96506-1.c.jj   2020-11-22 
> 19:11:44.000000000 +0100
> +++ gcc/testsuite/gcc.target/powerpc/pr96506-1.c      2024-11-21 
> 19:09:58.042577378 +0100
> @@ -1,7 +1,7 @@
>  /* PR target/96506 */
>  /* { dg-do compile } */
>  /* { dg-require-effective-target power10_ok } */
> -/* { dg-options "-mdejagnu-cpu=power10 -O2" } */
> +/* { dg-options "-mdejagnu-cpu=power10 -O2 -std=gnu17" } */
>  
>  extern void bar0();
>  extern void bar1();
> --- gcc/testsuite/gcc.target/powerpc/swaps-stack-protector.c.jj       
> 2020-01-12 11:54:38.000000000 +0100
> +++ gcc/testsuite/gcc.target/powerpc/swaps-stack-protector.c  2024-11-21 
> 19:12:01.487819286 +0100
> @@ -1,5 +1,5 @@
>  /* { dg-do compile } */
> -/* { dg-options "-fstack-protector -O3" } */
> +/* { dg-options "-fstack-protector -O3 -std=gnu17" } */
>  
>  /* PR78695: This code used to ICE in rs6000.c:find_alignment_op because
>     the stack protector address definition isn't associated with an insn.  */
> --- gcc/testsuite/gcc.target/powerpc/pr78543.c.jj     2024-06-04 
> 13:19:04.000000000 +0200
> +++ gcc/testsuite/gcc.target/powerpc/pr78543.c        2024-11-21 
> 19:09:13.071218226 +0100
> @@ -1,5 +1,5 @@
>  /* { dg-do compile { target { powerpc64*-*-* && lp64 } } } */
> -/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O1" } */
> +/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O1 -std=gnu17" } */
>  /* { dg-require-effective-target powerpc_vsx } */
>  
>  typedef long a;
> --- gcc/testsuite/gcc.dg/vect/pr48765.c.jj    2024-02-22 10:10:19.705018061 
> +0100
> +++ gcc/testsuite/gcc.dg/vect/pr48765.c       2024-11-21 18:54:59.592385168 
> +0100
> @@ -1,5 +1,5 @@
>  /* { dg-do compile { target { powerpc*-*-* } } } */
> -/* { dg-additional-options "-O3 -mdejagnu-cpu=power6 -mno-vsx" } */
> +/* { dg-additional-options "-O3 -mdejagnu-cpu=power6 -mno-vsx -std=gnu17" } 
> */
>  
>  enum reg_class
>  {
> 
>       Jakub

Reply via email to