On Thu, Nov 21, 2024 at 05:21:27PM -0800, Andrew Pinski wrote:
> While compiling libsanitizer for aarch64-linux-gnu, I noticed the new warning:
> ```
> ../../../../libsanitizer/asan/asan_interceptors.cpp: In function ‘char*
> ___interceptor_strcpy(char*, const char*)’:
> ../../../../libsanitizer/asan/asan_interceptors.cpp:554:6: warning: ‘if
> constexpr’ only available with ‘-std=c++17’ or ‘-std=gnu++17’
> [-Wc++17-extensions]
> 554 | if constexpr (SANITIZER_APPLE) {
> | ^~~~~~~~~
> ```
> So compile-rt upstream compiles this as gnu++17 (the current defualt for
> clang), so let's update it
> to be similar.
>
> Build and tested on aarch64-linux-gnu.
>
> PR sanitizer/117731
> libsanitizer/ChangeLog:
>
> * asan/Makefile.am: Replace gnu++14 with gnu++17.
> * asan/Makefile.in: Regenerate.
> * hwasan/Makefile.am: Replace gnu++14 with gnu++17.
> * hwasan/Makefile.in: Regenerate.
> * interception/Makefile.am: Replace gnu++14 with gnu++17.
> * interception/Makefile.in: Regenerate.
> * libbacktrace/Makefile.am: Replace gnu++14 with gnu++17.
> * libbacktrace/Makefile.in: Regenerate.
> * lsan/Makefile.am: Replace gnu++14 with gnu++17.
> * lsan/Makefile.in: Regenerate.
> * sanitizer_common/Makefile.am: Replace gnu++14 with gnu++17.
> * sanitizer_common/Makefile.in: Regenerate.
> * tsan/Makefile.am: Replace gnu++14 with gnu++17.
> * tsan/Makefile.in: Regenerate.
> * ubsan/Makefile.am: Replace gnu++14 with gnu++17.
> * ubsan/Makefile.in: Regenerate.
Please change the ChangeLog
s/am:/am (AM_CXXFLAGS):/g
> Signed-off-by: Andrew Pinski <quic_apin...@quicinc.com>
Ok with that nit changed.
I have a follow-up patch but will adjust it after you commit.
Jakub
