On 11/21/24 1:47 PM, Sam James wrote:
> Mark Wielaard <m...@klomp.org> writes:
> 
>> Hi Carlos,
>>
>> On Thu, 2024-11-21 at 12:04 -0500, Carlos O'Donell wrote:
>>> Adjust the DCO text to match the broader community usage including
>>> the Linux kernel use around "real names."
>>
>> We made a similar change to switch from "real names" to "known
>> identifies" for elfutils a year ago:
>> https://sourceware.org/cgit/elfutils/commit/CONTRIBUTING?id=b770e1c4def3532c7b59c4d2e4cd3cee26d4548b
>>
>> I suggest including the actual clarification in the explantion, so
>> there is no confusion about what is meant by "known identity":
>>
>> diff --git a/htdocs/dco.html b/htdocs/dco.html
>> index 68fa183b9fc0..f4bf17d2a6ec 100644
>> --- a/htdocs/dco.html
>> +++ b/htdocs/dco.html
>> @@ -54,8 +54,10 @@ then you just add a line saying:
>>  
>>  <pre>    Signed-off-by: Random J Developer 
>> &lt;ran...@developer.example.org></pre>
>>  
>> -using your real name (sorry, no pseudonyms or anonymous contributions.)  
>> This
>> -will be done for you automatically if you use `git commit -s`.
>> +using a known identity (sorry, no pseudonyms or anonymous contributions.)
>> +The name you use as your identity should not be an anonymous id or
>> +false name that misrepresents who you are.
>> +This will be done for you automatically if you use `git commit -s`.
>>  
>>  <p>Some people also put extra optional tags at the end.  The GCC project 
>> does
>>  not require tags from anyone other than the original author of the patch, 
>> but
>>
>> It looks like the cncf has an almost identical clarification.
> 
> I will note that our DCO in Gentoo was based on the kernel's, and we
> changed ours in April last year accordingly to align with this update
> too.

That's good to know.

Did you include any additional clarifying language?

I'd like to keep the language as simple as possible, and so I do not plan to
make any further changes to my patch.

I'm concerned that terms like "false" or "misrepresent" are context dependent
and may lead to more confusion.

I like that the linux kernel text is succinct.

-- 
Cheers,
Carlos.

Reply via email to