Rainer Orth <r...@cebitec.uni-bielefeld.de> writes:

> Solaris has modified versions of ASM_DECLARE_OBJECT_NAME on both i386
> and sparc.  When
>
> commit ce597aedd79e646c4a5517505088d380239cbfa5
> Author: Ilya Enkovich <ilya.enkov...@intel.com>
> Date:   Thu Aug 7 08:04:55 2014 +0000
>
>     elfos.h (ASM_DECLARE_OBJECT_NAME): Use decl size instead of type size.
>
> was applied, those were missed.  At the same time, the testcase was
> restricted to Linux though there's nothing Linux-specific in there, so
> the error remained undetected.
>
> This patch fixes the definitions to match elfos.h and enables the test
> on Solaris, too.
>
> Bootstrapped without regressions on i386-pc-solaris2.11 and
> sparc-sun-solaris2.11.
>
> Ok for trunk?

I've installed the patch as is for now to at least fix the Solaris side
of things.

> I noticed that both openbsd.h and mcore/mcore-elf.h have the same
> problem.  Since I can test neither of those, I left them alone.

The OpenBSD and Mcore maintainers can worry about their ports at their
leisure ...

> Besides, it should be possible to move the testcase out of
> gcc.target/i386, simultaneously restricting it to ELF targets.

... and we can move the testcase out of gcc.target/i386 if we want.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to