Evgeny Karpov <evgeny.kar...@microsoft.com> writes:
> This patch adds stdcall and cdecl attributes, which might be used for
> DLL export/import in MinGW.
If that's the main use case, did you consider putting the attributes
in the #if TARGET_DLLIMPORT_DECL_ATTRIBUTES block? Or is that not
appropriate? (Genuine question, in case it doesn't sound like one.)
Why is there no handling of the attributes? Are they just being
provided for compatibility with x86 code, and so are no-ops for aarch64?
It would be good to update the documentation in doc/extend.texi as well.
Thanks,
Richard
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.cc: Update.
> ---
> gcc/config/aarch64/aarch64.cc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index aa6b1c86ed1..f02f9c88b6e 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -869,6 +869,8 @@ static const attribute_spec aarch64_gnu_attributes[] =
> { "Advanced SIMD type", 1, 1, false, true, false, true, NULL, NULL },
> { "SVE type", 3, 3, false, true, false, true, NULL, NULL
> },
> { "SVE sizeless type", 0, 0, false, true, false, true, NULL, NULL },
> + { "cdecl", 0, 0, false, false, false, false, NULL, NULL },
> + { "stdcall", 0, 0, false, false, false, false, NULL, NULL
> },
> #if TARGET_DLLIMPORT_DECL_ATTRIBUTES
> { "dllimport", 0, 0, false, false, false, false, handle_dll_attribute,
> NULL },
> { "dllexport", 0, 0, false, false, false, false, handle_dll_attribute,
> NULL },
