On Nov 10, 2024, Jakub Jelinek <ja...@redhat.com> wrote: > On Sun, Nov 10, 2024 at 01:30:06PM -0300, Alexandre Oliva wrote:
>> I'm surprised the commit-time checker didn't catch them. > I'm surprised too, but don't want to try to push further broken commits just > to double check that. ;) You can leave that testing to me ;-) As in, I'm sure I'll eventually try to push commits with CL typos again, and then we'll know ;-) >> It used to, and that was very helpful to avoid typos in filenames. > Yes. > And I think it usually still does, I had one commit rejected because of such > a reason recently. Hmm... I have a theory. Since it'd been a while since I'd refreshed the tree as I posted the patchset, I refreshed it, pushed to my testing branch, and ran a test build before pushing the same commits onto the trunk. Could it be that the checker didn't test the first push because it was for an open branch, and then didn't test the second push because the commits were not new? -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive
