On Fri, 2024-11-08 at 12:35 +0100, Jakub Jelinek wrote:
> On Thu, Nov 07, 2024 at 02:35:34PM +0800, Kito Cheng wrote:
> > The patch set aims to update libsanitizer from upstream. The motivation is 
> > that
> > RISC-V is changing the shadow offset for AddressSanitizer, and I also plan 
> > to
> > submit another patch set to add dynamic shadow offset support for GCC.
> > 
> > This is my first time updating it, so I used my laptop and an AArch64 server
> > from cfram to run the regression tests. I tested on x86_64/Linux (Ubuntu 
> > 22.04)
> > and AArch64/Linux (Rocky 9.4), both with --with-build-config=bootstrap-asan 
> > and
> > performed a standard 3-stage build. No new regressions were introduced.
> > 
> > NOTE: I tried to run regression tests with
> > --with-build-config=bootstrap-asan, but I received warnings from
> > LeakSanitizer due to the pretty printer, which make the test results
> > unusable...
> 
> If pretty-printer now massively leaks, we should file a PR and get it fixed
> for GCC 15.
> 
> > Kito Cheng (4):
> >   libsanitizer: merge from upstream (61a6439f35b6de28)
> >   libsanitizer: Apply local patches
> >   libsanitizer: Improve FrameIsInternal
> >   libsanitizer: update test
> 
> Ok for trunk, but please mention in LOCAL_PATCHES all the 2/4, 3/4 and 4/4
> commits, not just 2/4 (and commit that as the last patch, separately
> from the series so that you don't need to repeat it any time git rebase
> is needed before pushing).

IIUC 4/4 shouldn't be in LOCAL_PATCHES?  It modifies our own test case,
not from the upstream.

-- 
Xi Ruoyao <xry...@xry111.site>
School of Aerospace Science and Technology, Xidian University

Reply via email to