Re: [PATCH] testsuite: arm: Use effective-target for nomve_fp_1 test

[Torbjorn SVENSSON]

On 2024-11-07 11:40, Christophe Lyon wrote:

Hi Torbjörn,

On Thu, 31 Oct 2024 at 19:34, Torbjörn SVENSSON
<torbjorn.svens...@foss.st.com> wrote:

Ok for trunk and releases/gcc-14?

--

Test uses MVE, so add effective-target arm_fp requirement.

gcc/testsuite/ChangeLog:

         * g++.target/arm/mve/general-c++/nomve_fp_1.c: Use
         effective-target arm_fp.

I see I made a similar change to the corresponding "C" test:
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624404.html

Is your patch fixing the same issue?

Yes, it looks like it's the same issue (and resolution).

Kind regards,
Torbjörn

Thanks,

Christophe

Signed-off-by: Torbjörn SVENSSON <torbjorn.svens...@foss.st.com>
---
  gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c 
b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
index e0692ceb8c8..a2069d353cf 100644
--- a/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
+++ b/gcc/testsuite/g++.target/arm/mve/general-c++/nomve_fp_1.c
@@ -1,9 +1,11 @@
  /* { dg-do compile } */
+/* { dg-require-effective-target arm_fp_ok } */
  /* { dg-require-effective-target arm_v8_1m_mve_ok } */
  /* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
     which could imply mve+fp depending on the user settings. We want to make
     sure the '+fp' extension is not enabled.  */
  /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
+/* { dg-add-options arm_fp } */

  #include <arm_mve.h>

--
2.25.1