On Wed, Nov 06, 2024 at 03:27:22PM +0000, Andrew Stubbs wrote:
> Ensure that the GOMP_MAX_VF does the right thing for explicit schedules, when
> offloading is enabled ("target" directives are present), and is inactive
> otherwise.
>
> This requires enabling the offload-dump scanning features previously only used
> in the libgomp testsuite. The automake scheme used there isn't a good fit
> here, so we probe the known devices manually.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/gomp/gomp.exp: Load scanoffload.exp and scanoffloadtree.exp.
> Set offload_targets when available.
> * gcc.dg/gomp/max_vf-1.c: New test.
> * gcc.dg/gomp/max_vf-2.c: New test.
> * gcc.dg/gomp/max_vf-3.c: New test.
I don't see how this can work. gomp.exp isn't prepared to find the libgomp
directory nor add -B options etc. Perhaps it appears to work if you have
your system gcc's libgomp installed, but that isn't the library that should
be used.
So, max_vf-1.c test can stay where it is, but the gomp.exp changes shouldn't
be done and max_vf-{2,3}.c should move to libgomp/testsuite/libgomp.c/
Jakub
