On Mon, Nov 4, 2024 at 2:01 PM Akram Ahmad <akram.ah...@arm.com> wrote: > > On 31/10/2024 08:00, Richard Biener wrote: > > On Wed, Oct 30, 2024 at 4:46 PM Akram Ahmad <akram.ah...@arm.com> wrote: > >> On 29/10/2024 12:48, Richard Biener wrote: > >>> The testcases will FAIL unless the target has support for .SAT_ADD - you > >>> want to > >>> add proper effective target tests here. > >>> > >>> The match.pd part looks OK to me. > >>> > >>> Richard. > >> Hi Richard, > >> > >> I assume this also applies to the tests written for the SAT_SUB pattern > >> too in that case? > > Yes, of course. > > I've taken a look at the effective target definitions in > target-supports.exp, but I can't > find anything relating to saturating arithmetic. I'm not sure if it's > only aarch64 which > doesn't support this yet either, otherwise I would try and add a > definition myself. Am > I missing any existing definitions that I can use for the > dg-effective-target keyword?
I looked and I can't find anything either. There's arm_sat_ok, but it guards intrinsics. For new effective targets I'd follow the optab names and modes so we can be specific. Like ssaddsi or usadddi. Richard. > Many thanks, > > Akram >
