On Mon, 2024-11-04 at 11:41 +0100, Tobias Burnus wrote: > Hi David > > David Malcolm wrote: > > On Fri, 2024-11-01 at 07:36 +0100, Tobias Burnus wrote: > > > Or you do the same as forhttps://gcc.gnu.org/PR115203 ; namely, > > > your commit > > > https://gcc.gnu.org/r15-866-g2dbb1c124c1e585dc413132d7a8d4be62c6b7baa > > > added: […] > > > + disable_event_localization (); > > Doing so for this case would require implementing a new feature in > > the > > diagnostic_context to suppress message translation, so I went for > > the > > simpler option (bigger hammer?) of using LC_ALL=C. > > As this should also fix PR115203, shouldn't r15-866-g2dbb1c124 then > be > reverted to have only one means (LC_ALL) to fix this instead of two > (disable_event_localization — only covering part of the code — and > LC_ALL)?
I don't think so. Ultimately we might to have a more fine-grained way to disable localization, so I want to keep r15-866-g2dbb1c124, but for now I wanted to unbreak the bootstrap, so I applied the "big hammer" version of the patch. Dave
